[RN][Codegen] Better support filtering out non linked platforms#48183
Merged
blakef merged 1 commit into0.76-stablefrom Dec 9, 2024
Merged
[RN][Codegen] Better support filtering out non linked platforms#48183blakef merged 1 commit into0.76-stablefrom
blakef merged 1 commit into0.76-stablefrom
Conversation
This was referenced Apr 1, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
As pointed out by this comment, the property dependency.platforms might not be defined, as the format
{ "dependencies": { "dependency-name": { "root": "path/to/dependency", } } }is also supported.
In this case, we assume that the library is linked to all platforms.
We don't consider the case were
dependency-name.rootis equal tonull, because that means that the library is not linked to the app at all, and in that case the dependency should be removed by the user.Changelog:
[General][Fixed] - Improve support for filtering out non supported platforms
Test Plan:
Tested on an app with this configuration and it does not crashes.