Add a new playground component to rntester#46632
Closed
shwanton wants to merge 1 commit intofacebook:mainfrom
Closed
Add a new playground component to rntester#46632shwanton wants to merge 1 commit intofacebook:mainfrom
shwanton wants to merge 1 commit intofacebook:mainfrom
Conversation
facebook-github-bot
added
CLA Signed
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D61972594 |
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D61972594 |
shwanton
force-pushed
the
export-D61972594
branch
from
957e751 to
3589cd0
Compare
Summary: Pull Request resolved: facebook#46632 Changelog: [rntester] Add Playground to RNTester for testing out features & submitting reproducers. **Context** - Adding the Playground from Catalyst to RNTester - This should help folks test React Native features for a particular version **Change** - Add a new playground component to RNTester - Add a new reducer action for opening an example from navbar press - Fixed typing issues - Add icon from this fb asset pack: https://www.internalfb.com/assets/set/facebook_icons/nucleus-beaker/variant_outline-size_24?q=beaker - Matched background color using this imagemagick script **dark** ``` convert input.png -fill 'rgb(178,180,186)' -colorize 100% output.png ``` **light** ``` convert input.png -fill 'rgb(81,82,84)' -colorize 100% output.png ``` Reviewed By: NickGerleman Differential Revision: D61972594
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D61972594 |
shwanton
force-pushed
the
export-D61972594
branch
from
3589cd0 to
9c7aca8
Compare
Contributor
|
This pull request has been merged in 256adca. |
Collaborator
|
This pull request was successfully merged by @shwanton in 256adca When will my fix make it into a release? | How to file a pick request? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
Changelog: [General][Added] Add Playground to RNTester for testing out features & submitting reproducers.
Context
Change
dark
light
Reviewed By: NickGerleman
Differential Revision: D61972594