Closed
Conversation
facebook-github-bot
added
CLA Signed
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D51152779 |
Base commit: caae388 |
NickGerleman
added a commit
to NickGerleman/yoga
that referenced
this pull request
Nov 9, 2023
Summary: X-link: facebook/react-native#41391 Pull Request resolved: facebook#1461 Converts usages of `YGEdge` within internal APIs to `yoga::Edge` scoped enum. With the exception of YGUnit which is in its own state of transition, this is the last public yoga enum to need to be moved to scoped enum form for usages internal to the Yoga public API. Changelog: [internal] Differential Revision: D51152779 fbshipit-source-id: adb8fecf7f653d9f816e1eaef615498cdf6de055
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D51152779 |
NickGerleman
force-pushed
the
export-D51152779
branch
from
86a70b9 to
a3be543
Compare
NickGerleman
added a commit
to NickGerleman/yoga
that referenced
this pull request
Nov 10, 2023
Summary: X-link: facebook/react-native#41391 Pull Request resolved: facebook#1461 Converts usages of `YGEdge` within internal APIs to `yoga::Edge` scoped enum. With the exception of YGUnit which is in its own state of transition, this is the last public yoga enum to need to be moved to scoped enum form for usages internal to the Yoga public API. Changelog: [internal] Reviewed By: rshest Differential Revision: D51152779 fbshipit-source-id: d76b850375c3d2c791ba8bd1dcf2c0b961a45738
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D51152779 |
NickGerleman
force-pushed
the
export-D51152779
branch
from
a3be543 to
d58b8ea
Compare
NickGerleman
added a commit
to NickGerleman/yoga
that referenced
this pull request
Nov 14, 2023
Summary: X-link: facebook/react-native#41391 Pull Request resolved: facebook#1461 Converts usages of `YGEdge` within internal APIs to `yoga::Edge` scoped enum. With the exception of YGUnit which is in its own state of transition, this is the last public yoga enum to need to be moved to scoped enum form for usages internal to the Yoga public API. Changelog: [internal] Reviewed By: rshest Differential Revision: D51152779 fbshipit-source-id: 5958bbbb9fbb65e7ea16e2fe3dd824e4f369fa9f
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D51152779 |
NickGerleman
force-pushed
the
export-D51152779
branch
from
d58b8ea to
2eb88b2
Compare
NickGerleman
added a commit
to NickGerleman/yoga
that referenced
this pull request
Nov 14, 2023
Summary: X-link: facebook/react-native#41391 Pull Request resolved: facebook#1461 Converts usages of `YGEdge` within internal APIs to `yoga::Edge` scoped enum. With the exception of YGUnit which is in its own state of transition, this is the last public yoga enum to need to be moved to scoped enum form for usages internal to the Yoga public API. Changelog: [internal] Reviewed By: rshest Differential Revision: D51152779 fbshipit-source-id: 7870a11a01ef224068341fb84afec82341f5d80f
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D51152779 |
NickGerleman
force-pushed
the
export-D51152779
branch
from
2eb88b2 to
03b1fd1
Compare
NickGerleman
added a commit
to NickGerleman/yoga
that referenced
this pull request
Nov 14, 2023
Summary: X-link: facebook/react-native#41391 Pull Request resolved: facebook#1461 Converts usages of `YGEdge` within internal APIs to `yoga::Edge` scoped enum. With the exception of YGUnit which is in its own state of transition, this is the last public yoga enum to need to be moved to scoped enum form for usages internal to the Yoga public API. Changelog: [internal] Reviewed By: rshest Differential Revision: D51152779 fbshipit-source-id: 6717ed59fcb6479e8b7973e10bcd2dfc5a50847b
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D51152779 |
NickGerleman
force-pushed
the
export-D51152779
branch
from
03b1fd1 to
a33a7fe
Compare
NickGerleman
added a commit
to NickGerleman/yoga
that referenced
this pull request
Nov 14, 2023
Summary: X-link: facebook/react-native#41391 Pull Request resolved: facebook#1461 Converts usages of `YGEdge` within internal APIs to `yoga::Edge` scoped enum. With the exception of YGUnit which is in its own state of transition, this is the last public yoga enum to need to be moved to scoped enum form for usages internal to the Yoga public API. Changelog: [internal] Reviewed By: rshest Differential Revision: D51152779 fbshipit-source-id: f9471715fc9bb5f7ec11b3579d7f570cddc3174f
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D51152779 |
NickGerleman
force-pushed
the
export-D51152779
branch
from
a33a7fe to
516021a
Compare
NickGerleman
added a commit
to NickGerleman/yoga
that referenced
this pull request
Nov 21, 2023
Summary: X-link: facebook/react-native#41391 Pull Request resolved: facebook#1461 Converts usages of `YGEdge` within internal APIs to `yoga::Edge` scoped enum. With the exception of YGUnit which is in its own state of transition, this is the last public yoga enum to need to be moved to scoped enum form for usages internal to the Yoga public API. Changelog: [internal] Reviewed By: rshest Differential Revision: D51152779 fbshipit-source-id: 7697e8b529e56bc18e250459aa25719e4a5c7128
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D51152779 |
NickGerleman
force-pushed
the
export-D51152779
branch
from
86884a1 to
32b95bb
Compare
NickGerleman
added a commit
to NickGerleman/yoga
that referenced
this pull request
Nov 22, 2023
Summary: X-link: facebook/react-native#41391 Pull Request resolved: facebook#1461 Converts usages of `YGEdge` within internal APIs to `yoga::Edge` scoped enum. With the exception of YGUnit which is in its own state of transition, this is the last public yoga enum to need to be moved to scoped enum form for usages internal to the Yoga public API. Changelog: [internal] Reviewed By: rshest Differential Revision: D51152779 fbshipit-source-id: de91bb48688a12dd42fe12ba2251436d47f90cec
NickGerleman
added a commit
to NickGerleman/yoga
that referenced
this pull request
Nov 25, 2023
Summary: X-link: facebook/react-native#41391 Converts usages of `YGEdge` within internal APIs to `yoga::Edge` scoped enum. With the exception of YGUnit which is in its own state of transition, this is the last public yoga enum to need to be moved to scoped enum form for usages internal to the Yoga public API. Changelog: [internal] Reviewed By: rshest Differential Revision: D51152779
NickGerleman
added a commit
to NickGerleman/yoga
that referenced
this pull request
Nov 25, 2023
Summary: X-link: facebook/react-native#41391 Converts usages of `YGEdge` within internal APIs to `yoga::Edge` scoped enum. With the exception of YGUnit which is in its own state of transition, this is the last public yoga enum to need to be moved to scoped enum form for usages internal to the Yoga public API. Changelog: [internal] Reviewed By: rshest Differential Revision: D51152779
NickGerleman
added a commit
to NickGerleman/yoga
that referenced
this pull request
Nov 25, 2023
Summary: X-link: facebook/react-native#41391 Converts usages of `YGEdge` within internal APIs to `yoga::Edge` scoped enum. With the exception of YGUnit which is in its own state of transition, this is the last public yoga enum to need to be moved to scoped enum form for usages internal to the Yoga public API. Changelog: [internal] Reviewed By: rshest Differential Revision: D51152779
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D51152779 |
NickGerleman
force-pushed
the
export-D51152779
branch
from
32b95bb to
de0c004
Compare
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D51152779 |
NickGerleman
force-pushed
the
export-D51152779
branch
from
de0c004 to
a365708
Compare
NickGerleman
added a commit
to NickGerleman/yoga
that referenced
this pull request
Nov 25, 2023
Summary: X-link: facebook/react-native#41391 Converts usages of `YGEdge` within internal APIs to `yoga::Edge` scoped enum. With the exception of YGUnit which is in its own state of transition, this is the last public yoga enum to need to be moved to scoped enum form for usages internal to the Yoga public API. Changelog: [internal] Reviewed By: rshest Differential Revision: D51152779
NickGerleman
added a commit
to NickGerleman/yoga
that referenced
this pull request
Nov 25, 2023
Summary: X-link: facebook/react-native#41391 Converts usages of `YGEdge` within internal APIs to `yoga::Edge` scoped enum. With the exception of YGUnit which is in its own state of transition, this is the last public yoga enum to need to be moved to scoped enum form for usages internal to the Yoga public API. Changelog: [internal] Reviewed By: rshest Differential Revision: D51152779
NickGerleman
added a commit
to NickGerleman/yoga
that referenced
this pull request
Nov 25, 2023
Summary: X-link: facebook/react-native#41391 Converts usages of `YGEdge` within internal APIs to `yoga::Edge` scoped enum. With the exception of YGUnit which is in its own state of transition, this is the last public yoga enum to need to be moved to scoped enum form for usages internal to the Yoga public API. Changelog: [internal] Reviewed By: rshest Differential Revision: D51152779
Differential Revision: https://internalfb.com/D51000389 fbshipit-source-id: fe2b4cbb82658931217b468967c24d582ecc978a
Summary: Yoga passes `MeasureMode`/`YGMeasureMode` to express constraints in how a box should be measured, given definite or indefinite available space. This is modeled after Android [MeasureSpec](https://developer.android.com/reference/android/view/View.MeasureSpec), with a table above `calculateLayoutImpl()` explaining the CSS terms they map to. This can be confusing when flipping between the spec, and code. This switches internal usages to the CSS terms, but leaves around `YGMeasureMode` since it is the public API passed to measure functions. Differential Revision: D51068417 fbshipit-source-id: 2a4ebd327bb63a97840b987e817e18587b4c06d8
Summary: Pull Request resolved: facebook#41391 X-link: facebook/yoga#1461 Converts usages of `YGEdge` within internal APIs to `yoga::Edge` scoped enum. With the exception of YGUnit which is in its own state of transition, this is the last public yoga enum to need to be moved to scoped enum form for usages internal to the Yoga public API. Changelog: [internal] Reviewed By: rshest Differential Revision: D51152779 fbshipit-source-id: e9293b6215a8f4a3c65852d583a29693ae34f8aa
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D51152779 |
NickGerleman
force-pushed
the
export-D51152779
branch
from
a365708 to
5e22e88
Compare
facebook-github-bot
pushed a commit
to facebook/litho
that referenced
this pull request
Nov 26, 2023
Summary: X-link: facebook/react-native#41391 X-link: facebook/yoga#1461 Converts usages of `YGEdge` within internal APIs to `yoga::Edge` scoped enum. With the exception of YGUnit which is in its own state of transition, this is the last public yoga enum to need to be moved to scoped enum form for usages internal to the Yoga public API. Changelog: [internal] Reviewed By: rshest Differential Revision: D51152779 fbshipit-source-id: 06554f67bfd7709cbc24fdd9a5474e897e9e95d8
Contributor
|
This pull request has been merged in b5f04d1. |
facebook-github-bot
pushed a commit
to facebook/yoga
that referenced
this pull request
Nov 26, 2023
Summary: X-link: facebook/react-native#41391 Pull Request resolved: #1461 Converts usages of `YGEdge` within internal APIs to `yoga::Edge` scoped enum. With the exception of YGUnit which is in its own state of transition, this is the last public yoga enum to need to be moved to scoped enum form for usages internal to the Yoga public API. Changelog: [internal] Reviewed By: rshest Differential Revision: D51152779 fbshipit-source-id: 06554f67bfd7709cbc24fdd9a5474e897e9e95d8
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
Converts usages of
YGEdgewithin internal APIs toyoga::Edgescoped enum.With the exception of YGUnit which is in its own state of transition, this is the last public yoga enum to need to be moved to scoped enum form for usages internal to the Yoga public API.
Changelog: [internal]
Differential Revision: D51152779