[LOCAL] properly support both libraries and use_frameworks#35624
Merged
cipolleschi merged 1 commit into0.71-stablefrom Dec 13, 2022
Merged
[LOCAL] properly support both libraries and use_frameworks#35624cipolleschi merged 1 commit into0.71-stablefrom
cipolleschi merged 1 commit into0.71-stablefrom
Conversation
facebook-github-bot
added
CLA Signed
cipolleschi
force-pushed
the
fix/properly_fix_use_frameworks
branch
from
509c3be to
82fe37f
Compare
kelset
approved these changes
Dec 13, 2022
Contributor
kelset
left a comment
kelset
left a comment
There was a problem hiding this comment.
Please remove these changes 👆
kelset
suggested changes
Dec 13, 2022
cipolleschi
force-pushed
the
fix/properly_fix_use_frameworks
branch
from
82fe37f to
a77b025
Compare
Contributor
Author
|
Fixed! |
kelset
approved these changes
Dec 13, 2022
cipolleschi
pushed a commit
that referenced
this pull request
Dec 14, 2022
facebook-github-bot
pushed a commit
that referenced
this pull request
Dec 14, 2022
Summary: Backporting a [fix](c6fa633) on the `ReactCommon.podspec` to properly support static libraries and static frameworks ## Changelog [IOS][FIXED] - Properly support static libraries and static frameworks Pull Request resolved: #35637 Test Plan: Tested in 0.71-RC4 Reviewed By: christophpurrer Differential Revision: D42029571 Pulled By: cipolleschi fbshipit-source-id: e562fe211931a0aebba282057589e5dd4fafe3ba
Merged
This was referenced Jan 8, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Following up this comment, this PR tries to fix the issue with
use_frameworks!and the missing header.Changelog
[IOS] [FIXED] - Properly exclude files depending on the
use_frameworks!option.Test Plan
CircleCI should be green