Add additional keyboardTypes to TextInput#249
Closed
bradleyboy wants to merge 2 commits intofacebook:masterfrom
Closed
Add additional keyboardTypes to TextInput#249bradleyboy wants to merge 2 commits intofacebook:masterfrom
bradleyboy wants to merge 2 commits intofacebook:masterfrom
Conversation
Ref: https://developer.apple.com/library/ios/documentation/UIKit/Reference/UI TextInputTraits_Protocol/index.html#//apple_ref/c/tdef/UIKeyboardType
Contributor
|
Sorry this is a duplicate of #265, the PR is newer but it's been rebase a couple times already. |
Contributor
|
Closed in favor of #256 which already landed. |
jfrolich
pushed a commit
to jfrolich/react-native
that referenced
this pull request
Apr 22, 2020
* Generate documentation * Remove upgrade scripts * Add commant to build documentation * Further work on documentation, added sample index page * Keep working on a documentation * Finish Animated main page and small CSS tweaks * Turn on namespaces, fix displaying -BsReactNative * Remove test files * Fix indentation, I really need to do sth about that in VSCode * Remove docs sources, will be always building * Remove comments and add editorconfig * Set up proper structure for handling CSS * Miscs * Additional work on Animated API * Add Status page - wip * Remove Status readme, its now in documentation * Add temporary ReasonReact-like Readme * Tweaks * Setup docs deployment * Test config * Trigger build * Fix config * Tweaks * Tweak * Tweak * Fix pin * Modify Circle config * Attach workspace properly * Pin odoc version * Experimental: Add cache for faster build times * Implement default settings accross jobs * Fix config issue in docs * Fix CircleCI cache keys * Try pinning odoc * Almost there, force pin command * Build BuckleScript first * Tweak build script * Add opam to path * Working on persisting Opam in path: * Tweaks * Hopefully last CI fix * Remove last readonly variable * Add deploy-docs lane * Little fix * Build documentation only on master * Fix case * Add CircleCI badge * Meta updates * Add @wokalski as a contributor * Add @saschatimme as a contributor * Add @mobily as a contributor * Add @arnarthor as a contributor * Add @grabbou as a contributor * Add @gunnigylfa as a contributor * Add @Trancever as a contributor * Add @ulrikstrid as a contributor * Add @kristinns as a contributor * Add @Rikkiabb as a contributor * Add @bjornj12 as a contributor * Add @chenglou as a contributor * Add @jamieparkinson as a contributor * Add @MoOx as a contributor * Add @szymonzmyslony as a contributor * Add @grsabreu as a contributor * Add @johannth as a contributor * Add @Gregoirevda as a contributor * Add @laynor as a contributor * Add @cullophid as a contributor * Add @gilbert as a contributor * Add @leomayleomay as a contributor * Add @maarekj as a contributor * Add @kennetpostigo as a contributor * Add @MarcelCutts as a contributor * Add @mciparelli as a contributor * Add @medson10 as a contributor * Add @tonyhb as a contributor * Add @zploskey as a contributor * Add @nhducit as a contributor * Add @alliannas as a contributor * Add @rodan-lewarx as a contributor * Add @arthur31416 as a contributor * Add @phated as a contributor * Add @bohdan-shulha as a contributor * Add @glennsl as a contributor * Add @lpalmes as a contributor * Add @Papierschiff as a contributor * Add @knowbody as a contributor * Add @Mikk36 as a contributor * Add @flash-gordon as a contributor * Add @robertpaul01 as a contributor * Add @ryanartecona as a contributor * Add @rrdelaney as a contributor * Add @shritesh as a contributor * Add @sscaff1 as a contributor * Add @Thomas0c as a contributor * Add @Denommus as a contributor * Add @eldh as a contributor * Add @sgny as a contributor * Add @thavishp as a contributor * Add @souhe as a contributor * Add @codinglawyer as a contributor * Updates * Update image sizes * Move to sep page to increase load time * Reword * Fix link * Mention contributions * Add @fhammerschmidt as a contributor * Add @cknitt as a contributor * Add @czystyl as a contributor * Add @reinvanimschoot as a contributor * Add @satya164 as a contributor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds the remaining keyboard types for iOS to TextInput:
https://developer.apple.com/library/ios/documentation/UIKit/Reference/UITextInputTraits_Protocol/index.html#//apple_ref/c/tdef/UIKeyboardType
Open to suggestions on the propTypes for keyboardType. Currently, they are: