Bump Android Support Library to 27.1.1#20586
Bump Android Support Library to 27.1.1#20586dulmandakh wants to merge 6 commits intofacebook:masterfrom
Conversation
facebook-github-bot
added
the
CLA Signed
|
|
||
| task wrapper(type: Wrapper) { | ||
| gradleVersion = '4.4' | ||
| gradleVersion = '4.8' |
There was a problem hiding this comment.
also use wrapper task to update, don't change gradle-wrapper.properties directly.
|
@facebook-github-bot shipit |
|
I will not rubber stamp and land your change for you @dulmandakh! I can import it for you and you can get your change reviewed by someone though :) |
|
maybe wait for 28 stable release. |
|
@gengjiawen maybe, but it might be better to migrate to AndroidX once it becomes stable. |
|
@hramos please review and merge. I found that some apps and libraries from Android use support library 27.x version. |
|
I think the most import thing is android gradle plugin compatible to 3.x, can we put that first ? @dulmandakh . |
|
@gengjiawen are you asking for changes, or is this PR good to go? |
|
this pr is good to go. This pr is split from a big pr, I want android gradle plugin compatible to 3.x comes first since it's more important. Bump to 28 can wait since it comes out recently. |
|
rebased to master, and it works. please merge 👍 |
|
@gengjiawen we shouldn't be blocking unrelated PRs because of gradle plugin 3.x. Or we should be working to improve RN tooling where possible. Yes, I agree that gradle plugin 3.x support is very important, so I took https://gradle.org/training/intro-to-gradle/ training and learnt some basics about gradle. Also I'm planning to create small PRs to cleanup and refactor gradle scripts, then make it compatible with gradle plugin 3.x. |
|
For now, the script is compatible with gradle 3.x, I think we should do it now. |
facebook-github-bot
added
the
Import Started
facebook-github-bot
left a comment
facebook-github-bot
left a comment
There was a problem hiding this comment.
hramos is landing this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
|
This pull request was closed by @dulmandakh in 874cca1. Once this commit is added to a release, you will see the corresponding version tag below the description at 874cca1. If the commit has a single |
Summary: This PR bumps Android Support Library version to 27.1.1. FYI, originally was a part of facebook#20026. Pull Request resolved: facebook#20586 Differential Revision: D9414901 Pulled By: hramos fbshipit-source-id: 580338e62a924c214accc5d944f17c81ad9e3f9f
Summary: This PR bumps Android Support Library version to 27.1.1. FYI, originally was a part of facebook/react-native#20026. Pull Request resolved: facebook/react-native#20586 Differential Revision: D9414901 Pulled By: hramos fbshipit-source-id: 580338e62a924c214accc5d944f17c81ad9e3f9f
hramos
removed
Import Started
Summary: This PR bumps Android Support Library version to 27.1.1. FYI, originally was a part of facebook/react-native#20026. Pull Request resolved: facebook/react-native#20586 Differential Revision: D9414901 Pulled By: hramos fbshipit-source-id: 580338e62a924c214accc5d944f17c81ad9e3f9f
Summary: This PR bumps Android Support Library version to 27.1.1. FYI, originally was a part of facebook#20026. Pull Request resolved: facebook#20586 Differential Revision: D9414901 Pulled By: hramos fbshipit-source-id: 580338e62a924c214accc5d944f17c81ad9e3f9f
Summary: This PR bumps Android Support Library version to 27.1.1. FYI, originally was a part of facebook#20026. Pull Request resolved: facebook#20586 Differential Revision: D9414901 Pulled By: hramos fbshipit-source-id: 580338e62a924c214accc5d944f17c81ad9e3f9f
5 participants
This PR bumps Android Support Library version to 27.1.1.
FYI, originally was a part of #20026.
Test Plan:
Everything builds and runs as normal.
Release Notes:
[ANDROID] [ENHANCEMENT] [Android Support Library] - Bump to version 27.1.1