[SwipeableFlatList] Fix #16685, fix opening rows doesn't close on swipe left a new row. #17668
Closed
zongwan wants to merge 2 commits intofacebook:masterfrom
zongwan:fix-SwipeableFlatList-onOpen
Closed
[SwipeableFlatList] Fix #16685, fix opening rows doesn't close on swipe left a new row. #17668zongwan wants to merge 2 commits intofacebook:masterfrom zongwan:fix-SwipeableFlatList-onOpen
zongwan wants to merge 2 commits intofacebook:masterfrom
zongwan:fix-SwipeableFlatList-onOpen
Conversation
facebook-github-bot
added
CLA Signed
Contributor
|
@zongwan I tried to find reviewers for this pull request and wanted to ping them to take another look. However, based on the blame information for the files in this pull request I couldn't find any reviewers. This sometimes happens when the files in the pull request are new or don't exist on master anymore. Is this pull request still relevant? If yes could you please rebase? In case you know who has context on this code feel free to mention them in a comment (one person is fine). Thanks for reading and hope you will continue contributing to the project. |
Contributor
Author
react-native-bot
added
Android
Ran Commands
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Fix #16685
According to acc1edd
Test Plan
Swipe two different rows and it will look great.
Related PRs
#16682
[CLOSED for reducing commits ] #17663
Release Notes
[ANDROID] [BUGFIX] [SwipeableFlatList] - fix opening rows doesn't close on swipe left a new row.
[IOS] [BUGFIX] [SwipeableFlatList] - fix opening rows doesn't close on swipe left a new row.