Skip to content

Comments

Fix packager.sh arg parsing#1413

Closed
philikon wants to merge 1 commit intofacebook:masterfrom
philikon:fix_packager_args
Closed

Fix packager.sh arg parsing#1413
philikon wants to merge 1 commit intofacebook:masterfrom
philikon:fix_packager_args

Conversation

@philikon
Copy link
Contributor

All option arguments currently get parsed as booleans. This fixes that and makes it possible again to run the packager with arguments, e.g.:

react-native/packager/packager.sh --root .

(This is a follow-up to D2089601 / b46c94.)

All option arguments get parsed as booleans. This fixes that and makes it possible again to run the packager with arguments, e.g.:

  react-native/packager/packager.sh --root .

(This is a follow-up to D2089601 / b46c94.)
@philikon
Copy link
Contributor Author

also cc @amasad @hedgerwang

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label May 26, 2015
@frantic
Copy link
Contributor

frantic commented May 26, 2015

👍

@frantic
Copy link
Contributor

frantic commented May 26, 2015

Actually see #1377 , @amasad started pulling it in

@frantic frantic closed this May 26, 2015
@philikon philikon deleted the fix_packager_args branch January 5, 2016 01:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants