Skip to content

Android - Fix Drawable v4 paths in Android Artifact Resources (Libraries) #13128

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
jpshelley wants to merge 11 commits into from
Closed

Android - Fix Drawable v4 paths in Android Artifact Resources (Libraries) #13128

Changes from all commits
Commits
Show all changes
11 commits
Select commit Hold shift + click to select a range
9ab29b8
Update to v4 suffix drawables
jpshelley Mar 23, 2017
767b41d
Revert "Update to v4 suffix drawables"
jpshelley Mar 24, 2017
1b9806f
Add v4 suffix for Library Projects
jpshelley Mar 24, 2017
ed0e0ce
Merge branch 'master' into Android-FixDrawableV4Paths
jpshelley Apr 6, 2017
918acea
Merge branch 'master' into Android-FixDrawableV4Paths
jpshelley Apr 13, 2017
1961735
Merge branch 'master' into Android-FixDrawableV4Paths
jpshelley Apr 15, 2017
3d911a5
Merge branch 'master' into Android-FixDrawableV4Paths
jpshelley Jul 28, 2017
be68074
Merge branch 'master' into Android-FixDrawableV4Paths
jpshelley Aug 27, 2017
03eb403
Merge branch 'master' into Android-FixDrawableV4Paths
jpshelley Nov 28, 2017
112336f
Merge branch 'master' into Android-FixDrawableV4Paths
jpshelley Jan 4, 2018
c712fb8
Merge branch 'master' into Android-FixDrawableV4Paths
jpshelley Mar 30, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 19 additions & 0 deletions react.gradle
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,6 +24,7 @@ void runBefore(String dependentTaskName, Task task) {
}

afterEvaluate {
def isAndroidLibrary = plugins.hasPlugin("com.android.library")
// Grab all build types and product flavors
def buildTypes = android.buildTypes.collect { type -> type.name }
def productFlavors = android.productFlavors.collect { flavor -> flavor.name }
Expand Down Expand Up @@ -101,6 +102,24 @@ afterEvaluate {
enabled config."bundleIn${targetName}" ||
config."bundleIn${buildTypeName.capitalize()}" ?:
targetName.toLowerCase().contains("release")

if (isAndroidLibrary) {
doLast {
def moveFunc = { resSuffix ->
File originalDir = file("${resourcesDir}/drawable-${resSuffix}")
if (originalDir.exists()) {
File destDir = file("${resourcesDir}/drawable-${resSuffix}-v4")
ant.move(file: originalDir, tofile: destDir)
}
}
moveFunc.curry("ldpi").call()
moveFunc.curry("mdpi").call()
moveFunc.curry("hdpi").call()
moveFunc.curry("xhdpi").call()
moveFunc.curry("xxhdpi").call()
moveFunc.curry("xxxhdpi").call()
}
}
}

// Hook bundle${productFlavor}${buildType}JsAndAssets into the android build process
Expand Down