fix(react-scripts): do not redirect served path if request may proxy#8442
Merged
andriijas merged 1 commit intofacebook:masterfrom Feb 8, 2020
unrevised6419:valentina
Merged
fix(react-scripts): do not redirect served path if request may proxy#8442andriijas merged 1 commit intofacebook:masterfrom unrevised6419:valentina
andriijas merged 1 commit intofacebook:masterfrom
unrevised6419:valentina
Conversation
Moved redirect middleware and noopSW middleware in WDS after hook So proxy, and before proxy will take precedence before redirect Closes #8417
unrevised6419
requested review from
ianschmitz,
iansu,
mrmckeb and
petetnt
as code owners
Contributor
|
Awesome work @iamandrewluca !! |
7 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Moved redirect middleware and noopSW middleware in WDS after hook
So proxy, and
beforeproxySetup will take precedence before redirect.Now when making a fetch request that does not start with
serverdPatnamewill check first the proxy middleware, then will redirect if not a proxy like request.Related #7259
Closes #8417