Correct webpack name casing#8433
Closed
lewislbr wants to merge 0 commit intofacebook:masterfrom
lewislbr:incorrect-webpack-casing
Closed
Correct webpack name casing#8433lewislbr wants to merge 0 commit intofacebook:masterfrom lewislbr:incorrect-webpack-casing
lewislbr wants to merge 0 commit intofacebook:masterfrom
lewislbr:incorrect-webpack-casing
Conversation
lewislbr
requested review from
amyrlam,
ianschmitz,
iansu,
mrmckeb and
petetnt
as code owners
Contributor
|
Nice find. Sorry for the "but" but, in https://webpack.js.org/configuration/dev-server/ they name |
Author
|
True! Will correct it. |
Contributor
|
@lewislbr what happened? |
Author
|
@andriijas Honestly, not sure. I cloned my remote branch thinking I had no local branch, but I had, pushed to it, both branches merged and the PR closed itself 😓. I will open a new PR with a clean commit. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
webpack should always be written in lower-case, according to webpack's branding guidelines, so I've corrected all incorrect instances, excluding bundle files.