fix: add template support for homepage, browserslist properties#8209
Closed
jimthedev wants to merge 1 commit intofacebook:masterfrom
Closed
fix: add template support for homepage, browserslist properties#8209jimthedev wants to merge 1 commit intofacebook:masterfrom
jimthedev wants to merge 1 commit intofacebook:masterfrom
Conversation
This change updates the init script to allow for the homepage property to be set by a template. The homepage field with a value of "." is used when running applications at non-root of a domain. Additionally this adds support for templates to customize the browserlist property. This is useful specifically when a template includes IE support out of the box.
jimthedev
requested review from
ianschmitz,
iansu,
mrmckeb and
petetnt
as code owners
Contributor
|
Hi @jimthedev, this is a great fix - however, someone is working on adding support for all Please chime in on that thread and thanks for your time. |
Contributor
|
We would aim to get this out in 3.4 BTW, so it should not be too far away. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change updates the init script to allow for the homepage property to be set by a template. The homepage field with a value of "." is used when running applications at non-root of a domain. Additionally this adds support for templates to customize the browserlist property. This is useful specifically when a template includes IE support out of the box.