Prefix apple-touch-icon links with PUBLIC_URL

[benblank]

The link for apple-touch-icon is the only URL in the templates' index.htmls that is relative, rather than using the %PUBLIC_URL% prefix.

Having all URLs in index.html be absolute makes it possible to host the site in one URL and alias index.html from another. This is helpful, for example, when proxying a site into an Azure Functions domain.

[mrmckeb]

I'm OK with this, but I thought that this worked without the full URL (it resolves to the same path)?

@ianschmitz @iansu any thoughts?

[ianschmitz]

Being consistent with the favicon makes sense to me.

[benblank]

I thought that this worked without the full URL (it resolves to the same path)?

It's a heck of a corner case, but say you have homepage in package.json set to /client/. If you then alias only / to /client/index.html on the server (a bit weird, but definitely convenient in some cases¹), then the apple-touch-icon would be resolved to <host>/logo192.png while everything else gets resolved to e.g. <host>/client/favicon.ico.

¹ Such as on an Azure Functions host, where you have to individually alias files in the root (to avoid also aliasing /api/, where your functions live). It's much more convenient to alias the single / path.