Merged
Conversation
Contributor
|
This fixes the failing tests on #7750 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #7782.
Updates
webpack-dev-serverfrom3.2.1to3.9.0.I was able to resolve the previous issues i experienced when trying the upgrade before in #7473. The error appears to be related to our usage of
sockjs-clientinside of thewebpackHotDevClientand jsdom. Switching to using native aWebSocketinstead made everything happy.yarn startworks nicely. Code changes cause page refresh, style changes causes a hot replacement of styles as expected, and error overlay works.I tagged as a breaking change for
react-dev-utilsonly as this change could potentially affect someone out there due to the change.