Add placeholders where old template READMEs used to be#7972
Merged
iansu merged 1 commit intofacebook:masterfrom Nov 13, 2019
Merged
Add placeholders where old template READMEs used to be#7972iansu merged 1 commit intofacebook:masterfrom
iansu merged 1 commit intofacebook:masterfrom
Conversation
ianschmitz
approved these changes
Nov 13, 2019
petetnt
reviewed
Nov 13, 2019
| console.log('Find out more about deployment here:'); | ||
| console.log(); | ||
| console.log(` ${chalk.yellow('https://create-react-app.dev/docs/deployment')}`); | ||
| console.log(` ${chalk.yellow('bit.ly/CRA-deploy')}`); |
Contributor
There was a problem hiding this comment.
I think the placeholders make sense, but I'd keep this as https://create-react-app.dev/docs/deployment so that the end users don't have to follow 3 links to end up in the same page.
Contributor
Author
There was a problem hiding this comment.
Whatever links we put in there basically have to work forever and I don't want to have a long list of old links to keep track of. We have a new domain name that we are going to switch all shortlinks over to.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Since there are millions of existing apps out there that link to the old template READMEs we should have a placeholder there that links to the new location.