Fix light background in docusaurus night mode#7936
Merged
andriijas merged 2 commits intofacebook:masterfrom Nov 13, 2019
Merged
Fix light background in docusaurus night mode#7936andriijas merged 2 commits intofacebook:masterfrom
andriijas merged 2 commits intofacebook:masterfrom
Conversation
endiliey
approved these changes
Nov 6, 2019
andriijas
reviewed
Nov 6, 2019
andriijas
reviewed
Nov 6, 2019
|
Looks good! thanks @heyimalex 🥇 |
andriijas
approved these changes
Nov 13, 2019
|
Will this change be active on next release? The live site currently isn't showing the changes from this PR. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #7930
Tested with the manual toggle, and with setting
prefers-color-scheme. Not sure if there's a cleaner way to do this, but it works.