added e2e test for checking typescript template with unsupported node#7844
Merged
iansu merged 1 commit intofacebook:masterfrom Nov 18, 2019
Merged
added e2e test for checking typescript template with unsupported node#7844iansu merged 1 commit intofacebook:masterfrom
iansu merged 1 commit intofacebook:masterfrom
Conversation
awaseem
requested review from
ianschmitz,
iansu,
mrmckeb and
petetnt
as code owners
Contributor
|
I'm not sure why the build didn't run on this. @ianschmitz any ideas? |
Contributor
Author
|
Oh I think it just took some time, but it just ran (and passed!) |
|
This pull request has been automatically marked as stale because it has not had any recent activity. It will be closed in 5 days if no further activity occurs. |
Contributor
|
We'd still like to merge this. Can you fix the conflicts? |
Contributor
Author
|
@iansu of course!!! can get it done EOD |
Contributor
Author
|
@iansu should be good to go, my new tests passed on the build pipeline |
Contributor
|
Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Another subset of #7839
I added some e2e tests based on the following bash script:
e2e-old-node.sh. I tested it on my local machine and I hope it runs as apart of the changes made toazure-pipelines.ymlThe test just installs node version 8.9.x and ensures that the code errors out