Add numeric separator support#7817
Add numeric separator support#7817ianschmitz merged 9 commits intofacebook:masterfrom tharun208:master
Conversation
|
Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please sign up at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need the corporate CLA signed. If you have received this in error or have any questions, please contact us at cla@fb.com. Thanks! |
|
Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks! |
|
Hi @ianschmitz, thanks for reviewing and I fixed the changes, can you check? |
|
Hi @ianschmitz, Is there any bug in your CI/CD script, it is running perfectly for some jobs and rest, it is suggesting me to add |
|
I'll take a look after the next run |
|
@ianschmitz, Is it good to go? or we can inspect the ci/cd script by giving a test run. |
|
@tharun208 i didn't see any failures in CI. Did i miss something? |
|
No @ianschmitz, it is good to go then |
|
Hi @ianschmitz, Do I need to do anything ? or is it good to get merged? |
|
Nope. All good. Thanks @tharun208! |
Closes #7329.
This PR has added the support for numeric supporters using babel plugin.