Fix wrong letter casing#7752
Merged
mrmckeb merged 1 commit intofacebook:masterfrom Sep 30, 2019
lewislbr:master
Merged
Conversation
lewislbr
requested review from
ianschmitz,
iansu,
mrmckeb and
petetnt
as code owners
Contributor
|
Hi @lewislbr, while I personally would have written https://english.stackexchange.com/questions/5366/which-is-correct-filename-file-name-or-filename |
Author
|
Hey @mrmckeb, I prefer fileName too, I just used filename as it seemed the standard in the file. We could use fileName for all variable names instead. |
Contributor
|
Thanks for your help! |
Author
|
Nice, you're welcome! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Just a small correction of the variable name casing, to match the use in the file of filename as a single word.