docs: fix module mapper regex in Flow documentation#7731
Merged
iansu merged 1 commit intofacebook:masterfrom Sep 25, 2019
FezVrasta:patch-5
Merged
docs: fix module mapper regex in Flow documentation#7731iansu merged 1 commit intofacebook:masterfrom FezVrasta:patch-5
iansu merged 1 commit intofacebook:masterfrom
FezVrasta:patch-5
Conversation
With the currently documented regex we catch relative imports, that then get wrongly mapped. For example, `./Foobar.js` will become `<PROJECT_ROOT>/src/./Foobar.js`, instead of `<PROJECT_ROOT>/src/the/real/file/path/Foobar.js`. The new regex will exclude imports starting with a dot (`.`)
FezVrasta
changed the title
FezVrasta
changed the title
Contributor
|
Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
With the currently documented regex we catch relative imports, that then get wrongly mapped.
For example,
./Foobar.jswill become<PROJECT_ROOT>/src/./Foobar.js, instead of<PROJECT_ROOT>/src/the/real/file/path/Foobar.js.The new regex will exclude imports starting with a dot (
.)