Ignore "jsx-a11y/aria-role" for React components#7393
Merged
ianschmitz merged 1 commit intofacebook:masterfrom Aug 12, 2019
deftomat:master
Merged
Ignore "jsx-a11y/aria-role" for React components#7393ianschmitz merged 1 commit intofacebook:masterfrom deftomat:master
ianschmitz merged 1 commit intofacebook:masterfrom
deftomat:master
Conversation
deftomat
requested review from
Timer,
amyrlam,
bugzpodder,
gaearon,
ianschmitz,
iansu,
mrmckeb and
petetnt
as code owners
ianschmitz
approved these changes
Aug 12, 2019
Contributor
ianschmitz
left a comment
ianschmitz
left a comment
There was a problem hiding this comment.
Looks good. I wonder why we haven't heard more people complaining about this?
Contributor
|
Thanks @deftomat ! |
Amazing, thanks for this! I was literally just about to open an issue “complaining” about it 😄 |
Contributor
Author
|
You're welcome! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As described in docs,
jsx-a11y/aria-roleESLint rule can be disabled for non-DOM elements.I'm pretty sure that we want to check only native HTML elements as a lot of developers can struggle when we raise a warning for the
roleproperty in their custom React components.