Remove unused dependencies in babel-preset-react-app#5818
Merged
iansu merged 5 commits intofacebook:masterfrom Aug 9, 2019
Merged
Remove unused dependencies in babel-preset-react-app#5818iansu merged 5 commits intofacebook:masterfrom
iansu merged 5 commits intofacebook:masterfrom
Conversation
Contributor
Author
|
That's my plan for checking if they're really unused. 😀 |
Contributor
Author
|
It looks like SVGR might need some of these. Let's try this again after we upgrade to SVGR 4: #5816 |
Contributor
|
Related: #6124 |
ianschmitz
requested review from
bugzpodder,
ianschmitz,
mrmckeb and
petetnt
as code owners
Contributor
|
Seems some of these are still required?
|
Contributor
Author
|
Well, CI passed. How confident are we in our tests? 😀 |
Contributor
Author
|
YOLO |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #5165