See https://github.com/extdn/extdn-phpcs/issues/49#51
See https://github.com/extdn/extdn-phpcs/issues/49#51schmengler merged 4 commits intoextdn:masterfrom jissereitsma:rule-deprecated-block-parents
Conversation
| return [ | ||
| [ | ||
| 'class' => 'Magento\Backend\Block\Widget\Form\Generic', | ||
| 'advice' => 'Refactor this to a UiComponent.' |
There was a problem hiding this comment.
I think it will not be clear for people who just started working with magento. I think it's better to add there any link to
explanation "why?" with example how to refactor it. Maybe it will be a good idea to update issue description with this info and add link to it?
There was a problem hiding this comment.
We use a standardized URL to document sniffs in the repo (it would be Extdn/Sniffs/Blocks/DeprecatedParentsSniff.md, but is missing from this PR)
But good question: shouldn't we show this URL in the messages?
There was a problem hiding this comment.
Doc has now been added: https://github.com/jissereitsma/extdn-phpcs/commit/f831df3134ee6a3f3b2707ebd11b31e218311668 And the rule warning now refers to the actual URL (which is not there yet): https://github.com/jissereitsma/extdn-phpcs/commit/078417c1bf148d9214cc34a337eaf41162096ba9
| /** | ||
| * @var string | ||
| */ | ||
| protected $message = 'The ObjectManager should not be injected into the constructor'; |
There was a problem hiding this comment.
| include_once($phpcsFile->getFilename()); | ||
|
|
||
| $class = Reflection::getClass($className); | ||
| $parentClass = $class->getParentClass(); |
There was a problem hiding this comment.
does reflection with the parent class work if it is not present?
There was a problem hiding this comment.
Yes, in my case it did. The benefit here is that you don't need to parse the use statement and class X extends Y implements Z construct. So no dependency with Magento.
In the Reflection utilities that I've used here, I've added exception handling so that when Magento is not present (or something else fails) the rule can be bypassed: https://github.com/extdn/extdn-phpcs/blob/master/Extdn/Utils/Reflection.php#L35 So, the rules that depend on this Reflection could work (report stuff) when Magento is present, but they will also work (but not report stuff) when Magento is not there. Kind of makes sense to me personally.
|
An entirely different point: This rule expects the code to be compliant with Magento 2.2 (hence the classes are deprecated, while under M2.1 they wouldn't be). But it would be much nicer if there is code in the rule itself to see whether this is the case. Using Reflection, this could be made possible. When the Magento code is present, for example a call |
3 participants
#49