-
Notifications
You must be signed in to change notification settings - Fork 246
chore: execute goimports to format the code #2924
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Summary of ChangesHello @findfluctuate, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request is a chore task focused on improving code consistency and readability. It applies the Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request applies goimports to format Go source files by organizing import statements. While the changes improve import ordering, I've identified an inconsistency in the grouping of third-party packages between the modified files. My review includes a suggestion to make the formatting consistent across the codebase. Otherwise, the changes are a good step towards standardizing the code style.
execution/evm/test/test_helpers.go
Outdated
| "github.com/celestiaorg/tastora/framework/types" | ||
| "github.com/golang-jwt/jwt/v5" | ||
|
|
||
| "github.com/stretchr/testify/require" | ||
|
|
||
| "github.com/celestiaorg/tastora/framework/docker" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The grouping of third-party and internal packages using multiple blank lines is inconsistent with the formatting in the other file modified in this PR (execution/evm/test_helpers.go in package evm), which uses a single block for all third-party imports. To maintain a consistent style, it's recommended to group all non-standard library packages into a single block, sorted alphabetically. This is the default behavior of goimports and would create a more uniform style across the codebase.
Signed-off-by: findfluctuate <[email protected]>
* main: chore: execute goimports to format the code (#2924) refactor(block)!: remove GetLastState from components (#2923) feat(syncing): add grace period for missing force txs inclusion (#2915) chore: minor improvement for docs (#2918) feat: DA Client remove interface part 2, add client for celestia blob api (#2909) chore: update rust deps (#2917) feat(sequencers/based): add based batch time (#2911) build(deps): Bump golangci/golangci-lint-action from 9.1.0 to 9.2.0 (#2914) refactor(sequencers): implement batch position persistance (#2908)
Overview
execute goimports to format the code