Skip to content

Use Pillow manipulation logic for grey-to-RGB conversion on EV3 to improve perf #497

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
WasabiFan merged 1 commit into from
Aug 31, 2018
Merged

Use Pillow manipulation logic for grey-to-RGB conversion on EV3 to improve perf #497

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 1 addition & 11 deletions ev3dev2/display.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -287,16 +287,6 @@ def _img_to_rgb565_bytes(self):
pixels = [self._color565(r, g, b) for (r, g, b) in self._img.getdata()]
return pack('H' * len(pixels), *pixels)

def _color_xrgb(self, v):
"""Convert red, green, blue components to a 32-bit XRGB value. Components
should be values 0 to 255.
"""
return ((v << 16) | (v << 8) | v)

def _img_to_xrgb_bytes(self):
pixels = [self._color_xrgb(v) for v in self._img.getdata()]
return pack('I' * len(pixels), *pixels)

def update(self):
"""
Applies pending changes to the screen.
Expand All @@ -308,7 +298,7 @@ def update(self):
elif self.var_info.bits_per_pixel == 16:
self.mmap[:] = self._img_to_rgb565_bytes()
elif self.platform == "ev3" and self.var_info.bits_per_pixel == 32:
self.mmap[:] = self._img_to_xrgb_bytes()
self.mmap[:] = self._img.convert("RGB").tobytes("raw", "XRGB")
else:
raise Exception("Not supported")

Expand Down