Skip to content

Comments

Ignore auto-generated code from checks#7414

Merged
gilluminate merged 3 commits intomainfrom
gill/ignore-autogen-code
Feb 18, 2026
Merged

Ignore auto-generated code from checks#7414
gilluminate merged 3 commits intomainfrom
gill/ignore-autogen-code

Conversation

@gilluminate
Copy link
Contributor

@gilluminate gilluminate commented Feb 18, 2026

Description Of Changes

Since auto-generated code doesn't need to be reviewed, but does need to be committed, it shouldn't count toward PR size limits. These changes provide an exclusion list of directories containing auto-generated code.

Code Changes

  • Update the Check PR Size github action to include a AUTOGENERATED_PATHS array of directories. Initially this list consists of:
    • 'clients/admin-ui/src/types/api/' (auto-generated from fidesplus openapi types)
    • 'clients/fides-js/docs/' (auto-generated markdown from the jsdocs in 'clients/fides-js/src/docs/')
  • Simplify some of the logic

Steps to Confirm

  1. I've included an arbitrary Type, auto-generated using npm run openapi:generate, open the results of the code size check and verify that these do not count toward the overall counts. (eg. "PR size check passed (13 lines, 2 files, 2 files excluded)")

Pre-Merge Checklist

  • Issue requirements met
  • All CI pipelines succeeded
  • CHANGELOG.md updated
  • UX feedback:
    • No UX review needed
  • Followup issues:
    • No followup issues
  • Database migrations:
    • No migrations
  • Documentation:
    • No documentation updates required

@vercel
Copy link
Contributor

vercel bot commented Feb 18, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
fides-plus-nightly Ready Ready Preview, Comment Feb 18, 2026 6:00pm
1 Skipped Deployment
Project Deployment Actions Updated (UTC)
fides-privacy-center Ignored Ignored Feb 18, 2026 6:00pm

Request Review

@gilluminate gilluminate marked this pull request as ready for review February 18, 2026 18:37
@gilluminate gilluminate requested a review from a team as a code owner February 18, 2026 18:37
@gilluminate gilluminate requested review from speaker-ender and removed request for a team February 18, 2026 18:37
@gilluminate gilluminate added this pull request to the merge queue Feb 18, 2026
@gilluminate gilluminate removed the request for review from speaker-ender February 18, 2026 18:38
@greptile-apps
Copy link
Contributor

greptile-apps bot commented Feb 18, 2026

Greptile Summary

Updates the PR size check GitHub Action to exclude auto-generated code directories from both line count and file count limits, and includes sample auto-generated files to verify the exclusion works.

  • Adds AUTOGENERATED_PATHS array to exclude clients/admin-ui/src/types/api/ and clients/fides-js/docs/ from PR size checks
  • Fixes a pre-existing inconsistency where totalLinesChanged was calculated from all files (including excluded ones) but changedFiles only counted non-excluded files — both metrics now consistently use non-excluded files only
  • Removes unused deletions variable
  • Includes auto-generated AccuracyMetrics type to demonstrate the exclusion mechanism

Confidence Score: 5/5

  • This PR is safe to merge — it only modifies a CI workflow to exclude auto-generated paths and includes auto-generated test files.
  • The changes are minimal and well-scoped: a CI workflow update with clear logic, a changelog entry, and auto-generated files. The workflow change actually fixes a pre-existing inconsistency. No production code is affected.
  • No files require special attention.

Important Files Changed

Filename Overview
.github/workflows/check_pr_size.yml Adds AUTOGENERATED_PATHS exclusion list, refactors filter logic, and fixes a pre-existing inconsistency where totalLinesChanged was computed from all files instead of only non-excluded files.
changelog/update-pr-size-check.yaml Standard changelog entry for the PR size check update.
clients/admin-ui/src/types/api/index.ts Auto-generated file: adds AccuracyMetrics type export, included to demonstrate the exclusion mechanism works.
clients/admin-ui/src/types/api/models/AccuracyMetrics.ts Auto-generated type definition for AccuracyMetrics, included to test the auto-generated path exclusion.

Last reviewed commit: 3578267

Copy link
Contributor

@greptile-apps greptile-apps bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

4 files reviewed, no comments

Edit Code Review Agent Settings | Greptile

Merged via the queue into main with commit fe18c9e Feb 18, 2026
45 checks passed
@gilluminate gilluminate deleted the gill/ignore-autogen-code branch February 18, 2026 18:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants