ENG-2595: Add read-only DSR policies list page#7403
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
1 Skipped Deployment
|
Co-authored-by: Cursor <cursoragent@cursor.com>
4586b60 to
a6d145a
Compare
a6d145a to
f3965a0
Compare
Update 7403-dsr-policies-list-page.yaml
f3965a0 to
8867f59
Compare
Update 7403-dsr-policies-list-page.yaml
8867f59 to
ea5a12b
Compare
Update 7403-dsr-policies-list-page.yaml
ea5a12b to
099cc38
Compare
Update 7403-dsr-policies-list-page.yaml
099cc38 to
c019a0f
Compare
Greptile SummaryThis PR adds a read-only DSR policies list page at Key points:
Confidence Score: 4/5
Important Files Changed
Last reviewed commit: b1c929b |
|
@greptile |
Update 7403-dsr-policies-list-page.yaml
b1c929b to
5ea9eb6
Compare
lucanovera
left a comment
There was a problem hiding this comment.
Nice work. The listing page works as expected, code changes look good. I think we make the header text visually look like the other pages. I also left an optional comment about optimizing with lodash.
|
@lucanovera I've implemented your suggestions, thanks. Ready for review again. |
lucanovera
left a comment
There was a problem hiding this comment.
All the changes look good! You might need an update to that cypress test that's failing, but I'll leave the approve now ✅
1ec4460 to
4915ee2
Compare
Ticket ENG-2595
Description Of Changes
Add a new read-only policies list page under Privacy Requests at
/privacy-requests/policies. The page displays all DSR policies with their name, key, execution timeframe, and action type tags from policy rules. Includes client-side search/filter by name or key, empty states, and loading skeletons.Also adds MSW mock data (14 policies) for local development
Code Changes
POLICY_READscopePOLICIES_ROUTEconstantSteps to Confirm
Pre-Merge Checklist
CHANGELOG.mdupdated