Skip to content

fix GeebkleMINI ESP32C3: add variable for support internal built in switch #9499

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
me-no-dev merged 3 commits into from
Apr 19, 2024
Merged

fix GeebkleMINI ESP32C3: add variable for support internal built in switch #9499

Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
4573695
fix: add variable for support internal built in switch
Apr 13, 2024
a037ef1
Merge branch 'master' into master
SooDragon Apr 15, 2024
6cca46c
Merge branch 'master' into master
me-no-dev Apr 15, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 7 additions & 3 deletions variants/Geekble_ESP32C3/pins_arduino.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,9 +3,13 @@

#include <stdint.h>

static const uint8_t LED_BUILTIN = 10;
#define BUILTIN_LED LED_BUILTIN // backward compatibility
#define LED_BUILTIN LED_BUILTIN // allow testing #ifdef LED_BUILTIN
static const uint8_t LED_BUILTIN = 10;
#define BUILTIN_LED LED_BUILTIN // backward compatibility
#define LED_BUILTIN LED_BUILTIN // allow testing #ifdef LED_BUILTIN

static const uint8_t SW_BUILTIN = 9;
#define BUILTIN_SW SW_BUILTIN // backward compatibility
Copy link
Member

@lucasssvaz lucasssvaz Apr 15, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there any sketch that uses BUILTIN_SW ? This is used for LED due to being like this in the past

#define SW_BUILTIN SW_BUILTIN // allow testing #ifdef SW_BUILTIN

static const uint8_t TX = 21;
static const uint8_t RX = 20;
Expand Down