Skip to content

Fix AdvancedWebServer.ino uptime conversion #9224

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
me-no-dev merged 2 commits into from
Feb 9, 2024
Merged

Fix AdvancedWebServer.ino uptime conversion #9224

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
861ef46
fix(examples): Fix AdvancedWebServer.ino uptime conversion
cydanil Feb 7, 2024
497830e
Fix build error
me-no-dev Feb 9, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions libraries/WebServer/examples/AdvancedWebServer/AdvancedWebServer.ino
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -44,8 +44,9 @@ void handleRoot() {
digitalWrite(led, 1);
char temp[400];
int sec = millis() / 1000;
int min = sec / 60;
int hr = min / 60;
int hr = sec / 3600;
int min = (sec / 60) % 60;
sec = sec % 60
Copy link
Member

@me-no-dev me-no-dev Feb 7, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

missing ; at the end of the line

Copy link
Member

@me-no-dev me-no-dev Feb 7, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

BTW looking at the code below, both min and sec are % 60, which makes the new code in effect the same as the old one. Also the old one looks OK, so I wonder how come you got the wrong values?


snprintf(temp, 400,

Expand Down