Make the type selector work for UPPER case elements#18
Open
stroiman wants to merge 2 commits intoericchiang:mainfrom
Open
Make the type selector work for UPPER case elements#18stroiman wants to merge 2 commits intoericchiang:mainfrom
stroiman wants to merge 2 commits intoericchiang:mainfrom
Conversation
stroiman
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The parser generates an error when parsing an element name in upper case, e.g.,
css.Parse("DIV"), which is working in a browser.I use this library for gost, a headless browser with JavaScript execution, primarily for testing Go/HTMX stack.
HTMX generates such selectors, as it constructs them from
tagNamewhich returns uppercase tag names for HTML elements, resulting in selectors likeDIV[id='root'].I believe this should fix the issue, I hope that there are not aspects of the problem I'm unaware of.