doc: add some documentation about raised exceptions#884
doc: add some documentation about raised exceptions#884sileht wants to merge 1 commit intoencode:masterfrom
Conversation
florimondmanca
left a comment
There was a problem hiding this comment.
Looks great! A bunch of copy nits to make this on par with the rest of the quickstart guide. :-) Definitely a super helpful addition!
8980ef7 to
13f8156
Compare
There was a problem hiding this comment.
Great thanks, let's wait for #869 to get in as this references HTTPStatusError.
|
If I understand correctly, half the exceptions are now in httpcore, so #869 and this PR should be rebased on master before being worked on more. In the meantime, I have to catch |
|
Not quite, no. HTTPX should only ever raise exceptions from its own package space. We should always wrap httpcore exceptions, and if there’s anywhere we’re not currently doing that, then we should consider it a bug. |
|
Oh okay, great, thanks for the clarification! |
|
Closing similarly to #869 and for housekeeping. These changes are super valuable but right now they're assuming we'd have already made the switch to I think while #1064 gets sorted out we can very much have docs about the current state of things — which improved since this PR was opened — which is " Thanks! 💟 |
No description provided.