Merged
Conversation
florimondmanca
commented
Mar 28, 2020
| typing.Dict[typing.AnyStr, typing.AnyStr], | ||
| typing.List[typing.Tuple[typing.AnyStr, typing.AnyStr]], | ||
| typing.Dict[StrOrBytes, StrOrBytes], | ||
| typing.Sequence[typing.Tuple[StrOrBytes, StrOrBytes]], |
Contributor
Author
There was a problem hiding this comment.
Note: this change from List to Sequence was required, or mypy would raise errors here about List being invariant (so not working well with unions of types):
Line 492 in 21f5337
yeraydiazdiaz
approved these changes
Mar 29, 2020
Contributor
yeraydiazdiaz
left a comment
yeraydiazdiaz
left a comment
There was a problem hiding this comment.
Good catch! LGTM 👍
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Extracted of #881 to reduce its scope.
We're using
AnyStrin several places to refer to "either bytes or str", i.e.Union[str, bytes].But
AnyStris not a synonym forUnion[str, bytes], so we should really just be usingUnion[str, bytes].(For details:
AnyStris meant to be used when we can accept either, but don't allow them to mix, so eg(s1: AnyStr, s2: AnyStr) -> AnyStr)would either accept str/str and return str, or accept bytes/bytes and return bytes. See typing docs.)This PR introduces a
StrOrBytesutil type to use across the codebase.