Conversation
|
Fantastic! I think we might also rejig how the imports are arranged, but I think we should probably leave that to a follow-up PR. (Ie. drop How do we want to approach this all release-wise/timing-wise? Presumably at least both this and #782 in a 0.12.0 release? |
Yup, that sounds good to me! |
|
Alright, I updated the docs -- only a few references to internal modules in logs, but otherwise nothing indicating that we've got anything missing at the top-level. This should be ready for review! I'll issue a follow-up for reorganizing imports. |
lovelydinosaur
left a comment
lovelydinosaur
left a comment
There was a problem hiding this comment.
Good stuff, this'll be a really nice bit of tightening up!
I'm happy for this to go in whenever you are, @florimondmanca.
(Essentially whenever we're at a point where we're confident we want to start pressing ahead on a 0.12.0)
| from httpx.content_streams import encode | ||
| from httpx.dispatch.base import AsyncDispatcher | ||
| from httpx.utils import format_form_param | ||
| from httpx._config import CertTypes, TimeoutTypes, VerifyTypes |
There was a problem hiding this comment.
Incidentally, it looks like we've erronously left the signature as send(request, verify, cert, timeout) in a bunch of these and other test cases, rather than switching to send(request, timeout) on the dispatch interface.
We're missing those because we're not type checking our test cases.
Not related to this PR, so doesn't neccessarily need to change here, but this helps highlight it, since we're pulling in more private API that we might otherwise expect.
|
What do we reckon then? Hit "Go" on this one now, and then start drawing up whatever we want in a 0.12 release? |
|
Yup, I think we’re ready for getting 0.12 together. :) |
|
Okay, let's roll this one now, then. |
2 participants
Fixes #772
Still need to confirm…