Conversation
Contributor
There was a problem hiding this comment.
Somes initial comments.
Just to confirm — this mechanism only intervenes at the time of making a request, correct? I'm wondering how long requests (e.g. those using e.g. read_timeout=20) would be affected by this change. I assume that while the request is executing, the connection is not considered keep-alive, so we're all good?
Co-Authored-By: Florimond Manca <florimond.manca@gmail.com>
Contributor
Author
|
Have made some cleanups based on the review. I'd like for all of this to be a bit tighter, as part of #624, but it seems sensible to approach it incrementally, and at least address the issue for now. |
florimondmanca
approved these changes
Dec 11, 2019
Contributor
florimondmanca
left a comment
florimondmanca
left a comment
There was a problem hiding this comment.
Just a small nit then this looks good to me!
This was referenced Dec 12, 2019
Merged
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #34
Closes #95 (as best we can)
Closes #289
Closes #381