Client handles redirect + auth#552
Merged
lovelydinosaur merged 24 commits intomasterfrom Nov 27, 2019
Merged
Conversation
Co-Authored-By: Florimond Manca <florimond.manca@gmail.com>
Contributor
Author
Contributor
|
@tomchristie The only thing itching me on this is that we’re back with having lots of redirect utility helper methods on the Client. They used to be neatly encapsulated in the middleware class. Any chance we can keep redirect-as-middleware and the benefits from the refactoring here? |
Contributor
Author
|
I'm not really fussed about it - they're neatly demarked. (In the same way as the I'd far rather we have a mostly linear chain of control to follow through, like this. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Builds on #544
Drops redirect and auth from being middleware, and just handles them on the
Clientinstance.