changed timeout, cert, verify, trust_env args as client instance.#516
changed timeout, cert, verify, trust_env args as client instance.#516cansarigol wants to merge 2 commits intoencode:masterfrom
Conversation
7dbc700 to
f832847
Compare
|
This PR is a much bigger footprint that I was expecting for #505 - I don't think it matches what I'd intended there. The only changes ought to be in the In that function, (Although If I've missed or misunderstood something that's needed here then happy to talk that through.) |
|
Ahh sorry, I thought that you want to change to pass these arguments as Client instance.
api.request calls client.request with these arguments. this PR is to change this per-request approach. I will check the issue again. |
|
Hi here, I think we can close this one in favor of #528. Thanks for initially tackling this @cansarigol. :) |
|
I couldn't find any time to pursue this. Thanks |
Closes #505