Always treat timeout=None as default timeout#492
Closed
florimondmanca wants to merge 4 commits intorefactor/timeout-testsfrom
Closed
Always treat timeout=None as default timeout#492florimondmanca wants to merge 4 commits intorefactor/timeout-testsfrom
florimondmanca wants to merge 4 commits intorefactor/timeout-testsfrom
Conversation
florimondmanca
changed the title
florimondmanca
force-pushed
the
feat/timeout-none-defaults
branch
from
3137bfd to
60f8c1b
Compare
This was referenced Oct 20, 2019
Contributor
Author
|
Closed in favor of exploring #433 (comment) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Spun up from #490. Refs #433.
Note: this is based on #491, so #491 must be merged first. Will change base branch once it gets merged.
As a result of this PR:
timeout=Nonealways means "use the defaults". This applies to our users, but also components in our code (clients and dispatchers in particular).config.pyonly. (AndDEFAULT_TIMEOUT_CONFIGis only used there, and in some of the tests.)