Fix bug when using client without timeouts under 3.6#383
Merged
sethmlarson merged 1 commit intomasterfrom Sep 25, 2019
Merged
Conversation
florimondmanca
force-pushed
the
fix/sync-client-no-timeout
branch
from
0443e85 to
c6c7058
Compare
dmoerner
added a commit
to dmoerner/pytorrent
that referenced
this pull request
Mar 1, 2025
Legacy asyncio timeout code was causing read races. The exact cause of these races is still under investigation, but they have been significantly reduced with the removal of this code. They are suspected to be connected to a race between a reader and the timeout cancellation of that reader. See encode/httpx#383, for example. Also handle other named exceptions. This code is now able to successfully download a complete torrent file.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #382 cc @StephenBrown2