Closed
Conversation
3 tasks
T-256
approved these changes
Jan 25, 2024
Contributor
T-256
left a comment
T-256
left a comment
There was a problem hiding this comment.
LGTM 🎉
Is Removed section missed?
From #3022 (comment):
Also, we have other deprecated drops those pending to remove in v1.0.0 (IIUC):
proxies=data=(non-Mapping objects)cookies=(per-request)
Contributor
Author
|
@encode/maintainers How do we feel about this? It's a more coherent, slightly stricter take on the API which all fits together really neatly. |
sscherfke
added a commit
to sscherfke/nicegui
that referenced
this pull request
Feb 3, 2024
- The "^" specifier is often too restrictive for 0.* versions so I would not recommend to use it in these cases: https://python-poetry.org/docs/dependency-specification/ - Markdown2: The issue from 2.4.11 was fixed in 2.4.12: - zauberzeug#2154 - trentm/python-markdown2#546 - https://github.com/trentm/python-markdown2/blob/master/CHANGES.md#python-markdown2-2412 - Watchfiles: Doesn't look like v1 will introduce breaking changes: samuelcolvin/watchfiles#186 - python-multipart: "^0.06" is "==0.0.6" which is too strict and at this stage, any release can potentially add breaking changes - aiofiles: Uses CalVer and 24.0.0 is as likely to introduce breaking changes as 23.2.0. - httpx: It does not look like 1.0.0 will introduce breaking changes (if you already fixed any deprecation warnings). Testing against the 1.0.0beata0 is advisable, though. encode/httpx#3069 - ifaddr: Development is rather slow, package looks quite stable. I don't think that a 0.3.0 will add breaking changes and a 1.0 is not in sight. - pytest-asyncio: Restriction to >=0.19,<0.20 seems unwanted and updates are needed for recent pytest versions - pytest: Has there been a reason to not support pytest7? pytest8 currently breaks some plugins, but this should be fixed soon. Fixes: zauberzeug#2485
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I'm drafting up here what our 1.0 release notes could look like, so that we've a single point of reference for deciding what does and does not make the cut.
Let's take a look...
Simplified transport configuration
As described at #947 (comment)
Includes PRs...
httpx.NetworkOptionsconfiguration. #3052httpx.Versionconfiguration. #3051app=...in favor of explicitWSGITransport/ASGITransport. #3050httpx.SSLContextconfiguration. #3022httpx.Mountstransport class. #3070Stricter parameters
We don't necessarily need these changes, and I've not discussed them elsewhere. However they do align with a stricter more explicit approach. Zen of Python etc. I'd be perfectly happy dropping these, but might be worthwhile. Can discuss the motivation more in due course.
Minor cleanups
Response.elapsedis a tidy one to remove, and can replaced with an example of how to handle it using event hooks. Discussion at Dropping `.elapsed` in favor of event hooks. #3012Environment variables
The changes in "simplified transport configuration" end up removing all auto-environment-variable based configuration by default. There's easy migrations for re-enabling the existing functionalities.
Dependencies