update requests compatibility docs on query and form params#2461
Merged
lovelydinosaur merged 1 commit intoencode:masterfrom Nov 25, 2022
Merged
update requests compatibility docs on query and form params#2461lovelydinosaur merged 1 commit intoencode:masterfrom
lovelydinosaur merged 1 commit intoencode:masterfrom
Conversation
Contributor
Not sure. We could leave it as-is and await further feedback perhaps? |
Contributor
Author
Sounds good! |
This was referenced Sep 24, 2024
samclearman
pushed a commit
to titanmsp/httpx
that referenced
this pull request
Apr 26, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Following up on #2330 (reply in thread) I added a note about requests compatibility with form data and query params -- namely that httpx only supports dictionaries whereas requests also supports lists of tuples.
As suggested, I added this note after the Query Parameters section, however, it might also bear mentioning in the Request Content section?