Perform port normalization for http, https, ws, wss, and ftp schemes.#1603
Merged
lovelydinosaur merged 1 commit intomasterfrom Apr 27, 2021
Merged
Perform port normalization for http, https, ws, wss, and ftp schemes.#1603lovelydinosaur merged 1 commit intomasterfrom
http, https, ws, wss, and ftp schemes.#1603lovelydinosaur merged 1 commit intomasterfrom
Conversation
florimondmanca
approved these changes
Apr 27, 2021
Contributor
florimondmanca
left a comment
There was a problem hiding this comment.
I'm happy enough with this. Thanks for the useful reference!
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Normalize the port component of URLs, so that...
Following this part of the WHATWG spec...
And using the set of default ports as defined by https://url.spec.whatwg.org/#url-miscellaneous
I figure this probably helps iron away a few possible corner cases. It more neatly matches browser behaviour, and it's in line with other aspects of normalization that we're providing for, eg...
It also has the nice property that
url.netlocnow properly encapsulates the same value that ought to be used for the value of theHostheader.