Differentiate between 'url.host' and 'url.raw_host'#1590
Merged
lovelydinosaur merged 7 commits intomasterfrom Apr 23, 2021
Merged
Differentiate between 'url.host' and 'url.raw_host'#1590lovelydinosaur merged 7 commits intomasterfrom
lovelydinosaur merged 7 commits intomasterfrom
Conversation
Contributor
|
Wouldn't |
StephenBrown2
approved these changes
Apr 22, 2021
Contributor
StephenBrown2
left a comment
There was a problem hiding this comment.
Just a couple typos, and the previous question about what raw means.
Co-authored-by: Stephen Brown II <Stephen.Brown2@gmail.com>
Co-authored-by: Stephen Brown II <Stephen.Brown2@gmail.com>
Co-authored-by: Stephen Brown II <Stephen.Brown2@gmail.com>
Co-authored-by: Stephen Brown II <Stephen.Brown2@gmail.com>
Co-authored-by: Stephen Brown II <Stephen.Brown2@gmail.com>
Contributor
Author
|
Raw, as in the "the raw bytes on the wire", or "the raw ingredients that make up the cake". Or, in baking... The raw ingredients: Similar usage of "Raw" in other technical docs. |
Contributor
Author
|
Thanks so much for the review @StephenBrown2. |
Contributor
I think it was mainly just a copy-paste issue that got propagated, but no more |
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refs #1275
Throughout our URL model we're differentiating neatly between byte-wise cases and str cases.
We're always using bytes when escaping is not applied, and str when escaping is applied.
Eg...
This pull request is a proposal for treating IDNA domain names similarly, so...
For API consistency this also necessarily results in
url.netlocbecoming a byte interface, which actually makes sense for the contexts in which it is used.Finally we also introduce
.raw_schemefor a byte-wise representation of the scheme, for a nice consistency so that: