Merged
Conversation
JayH5
reviewed
Sep 21, 2020
Co-authored-by: Jamie Hewland <jamie.hewland@hpe.com>
Contributor
|
Sounds good to me, great one! |
Contributor
Author
|
Right, let's keep the CLI separate. No good reason for us to bog ourselves down in a whole extra layer of API considerations (eg. which flags do we support on the command line) when we're so very close to a 1.0 release now. I'm going to push on again, and get this released. Where does this leave us after this?...
We'll then also want to go through the API docs, and make sure that all the public API is being properly exposed in the docs. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pushing this up so that we can figure out what else we want to block a 0.15 release on.
At the moment my thoughts would be...
.request,.arequest, since it'll otherwise end up blocking other work.request(method, url, headers, stream, ext) -> status_code, headers, stream, ext. See Finalising the Transport API for 1.0. #1274 (comment) - Might need discussion, but it's an easy switch to make, and better to make it sooner rather than later.I think other stuff can wait for nice smaller increments in the 0.15.x series. The only remaining API changes expected at that point are the possible transport API -> transport API as a context manager switch, and some very minor review over all the model classes. (Note that
URLis now complete in this regard.)What do we think, and am I missing anything critical here?
0.15.0
Added
response.num_bytes_downloaded. (Pull Add progress to streaming download #1268)Request(content=...)for byte content, instead of overloadingRequest(data=...)(Pull Seperatecontent=...anddata=...parameters #1266)url.copy_with(...). (Pull Finesse URL properties #1285)Requestinstances, vs defaultclient.headers. (Pull Header refinements #1248)AsyncClientinstances will now raise warnings if garbage collected. (Pull Issue warning on unclosedAsyncClient. #1197)Response(content=..., text=..., html=..., json=...)for creating usable response instances in code. (Pull SupportResponse(content=<bytes iterator>)#1265, Support Response(text=...), Response(html=...), Response(json=...) #1297)Changed
url.pathis now URL escaped. (Pull Finesse URL properties #1285)url.userinfoandurl.queryare not URL escaped, and so return bytes. (Pull Finesse URL properties #1285)url.authorityproperty in favour ofurl.netloc, since "authority" was semantically incorrect. (Pull Finesse URL properties #1285)url.full_pathproperty in favour ofurl.raw_path, for better consistency with other parts of the API. (Pull Finesse URL properties #1285)chardetlibrary for auto-detecting charsets, instead defaulting to a simpler approach when no charset is specified. (Drop chardet #1269)Fixed
.netrclookups should use host, not host+port. (Pull NetRC lookups should use host, not host+port #1298)Removed
URLLib3Transportclass no longer exists. We've published it instead as an example of a custom transport class. (Pull Drop urllib3 in favor of public gist #1182)request.timerattribute, which was being used internally to setresponse.elapsed. (Pull Droprequest.timerattribute. #1249)response.decoderattribute, which was being used internally. (Pull Minor decoder refactoring. #1276)Request.prepare()is now a private method. (Pull Refactoring of models api #1284)