Add proxies parameter to top-level API functions#1198
Merged
Conversation
Contributor
florimondmanca
left a comment
florimondmanca
left a comment
There was a problem hiding this comment.
Nice, thanks!
tests
Sure! Perhaps a single test against httpx.request is enough here, but up to you!
Contributor
Author
|
I find it a little difficult to test whether these parameters passed to top-level API functions are working as expected, do you have any ideas? |
Contributor
|
I see! Indeed I went through our proxy tests here and they're mostly about the proxy routing functionality - no existing test actually integrates with HTTPCore and a live proxy. Well no sweat then, I think it's alright (we certainly don't have tests for all options in the top level API anyway). |
florimondmanca
approved these changes
Aug 20, 2020
Contributor
florimondmanca
left a comment
florimondmanca
left a comment
There was a problem hiding this comment.
💯
Found a tiny typo
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #1195
Should I add tests to cover these parameters in top-level API functions?