Enable redirects by default for HEAD requests#1183
Merged
florimondmanca merged 3 commits intoencode:masterfrom Aug 16, 2020
Merged
Enable redirects by default for HEAD requests#1183florimondmanca merged 3 commits intoencode:masterfrom
florimondmanca merged 3 commits intoencode:masterfrom
Conversation
florimondmanca
approved these changes
Aug 16, 2020
Contributor
florimondmanca
left a comment
florimondmanca
left a comment
There was a problem hiding this comment.
Great, thanks! I'll add a test in a follow-up PR. :-)
florimondmanca
changed the title
Contributor
Author
|
Sounds great. |
j178
added a commit
that referenced
this pull request
Aug 20, 2020
Merged
j178
added a commit
that referenced
this pull request
Aug 20, 2020
j178
added a commit
that referenced
this pull request
Aug 20, 2020
j178
added a commit
that referenced
this pull request
Aug 20, 2020
Merged
This was referenced Mar 21, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix #1146
This PR sets default
allow_redirectstoTrue. It wasFalsebefore this PR.This will align our behavior with most other http request libraries, except for Requests.