response cookies fix#1153
Closed
djigit0s wants to merge 1 commit intoencode:masterfrom
djigit0s:master
Closed
Conversation
Contributor
|
Thanks for having a go at this! Your PR is absolutely fine, but I've drafted up another so that we've got a test case to prevent regressions here... #1156 Really appreciate you raising this as an issue. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix response cookies in 0.14.0. Didn't return all headers. This error is described here #1151
I apologize if I did not correctly formulate, this is my first PR