Allow disabling auth per-request using auth=None#1115
Merged
florimondmanca merged 4 commits intomasterfrom Aug 11, 2020
Merged
Conversation
Contributor
Author
|
Closed in favor of #1116 |
lovelydinosaur
approved these changes
Aug 11, 2020
Contributor
lovelydinosaur
left a comment
lovelydinosaur
left a comment
There was a problem hiding this comment.
Looks good to me, yup!
Merged
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1004
Switches request and verb handlers to default to
auth=UNSET, so thatauth=Nonecan be treated as "no auth on this request" (instead of "use default auth from the client").Right now this is only possible using an empty
Authinstance:which I'd agree is not intuitive (and it also works "by chance" because
Authhappens to be a "do-nothing" implementation, rather than a strict base class interface that raisesNotImplementedError).Note that this now differs from the behavior of
requests, which treatsauth=Noneas "use the default" (see #1004 (comment)).