Conversation
florimondmanca
left a comment
There was a problem hiding this comment.
Some comments
- I see we added models such as
URLandOrigin, which also exist currently in HTTPX. What's the cohabitation strategy? Will these be re-exposed in HTTPX? If they are copies from HTTPX then fine, otherwise are there API changes? - Should we ping some folks of extensions/libraries building upon on
httpcore? For community purposes and also to assess that the new API still fits the bill for existing use cases? - I'm not sure about
py.typed-- the diff shows it as deleted? We should make sure to keep it, I believe?
There are (Trying to find a good balance between "low-level API that doesn't deal with any fancy-pants models that just introduce extra surface area to wrangle, and hide from the developer what actual byte representations are like going to go out over the wire" vs. "user friendly API". I've not doc'ed up the models yet, but there's a starter on it, here)
Sure - any suggestions beyond this discussion?
Good catch - sorted! |
|
Right come on then, best just push on with this, eh? |
See discussion #419
I'm breaking my own rules here with a mega PR that's pulling in all of https://github.com/tomchristie/httpcore-the-directors-cut but there we are. Sometimes these things need doing.