Fix asyncio SSL warning when using proxy tunneling#249
Merged
florimondmanca merged 2 commits intomasterfrom Dec 7, 2020
Merged
Fix asyncio SSL warning when using proxy tunneling#249florimondmanca merged 2 commits intomasterfrom
florimondmanca merged 2 commits intomasterfrom
Conversation
JayH5
approved these changes
Dec 7, 2020
Contributor
JayH5
left a comment
JayH5
left a comment
There was a problem hiding this comment.
Good work figuring this out 👍
httpcore/_backends/asyncio.py
Outdated
Comment on lines
123
to
124
| # Initialize the protocol, so the reader is made aware of being tied to | ||
| # a TLS connection. |
Contributor
There was a problem hiding this comment.
I always find the asyncio protocol/transport stuff very confusing, but this comment seems the wrong way around? This change is to make the protocol aware of the TLS connection.
Contributor
Author
There was a problem hiding this comment.
Ah, well yeah you're right. I'm confused too 😆
florimondmanca
commented
Dec 7, 2020
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes encode/httpx#859
Turns out we need to call
protocol.connection_made(). It callsstream_reader.set_transport(...), as well as a bunch of other stuff, including marking the reader as being "over SSL", which fixes the warning saw in the issue.See encode/httpx#859 (comment) for the detailed analysis.