prefer this.import instead of app.import#220
Open
brendenpalmer wants to merge 1 commit intoember-cli:masterfrom
Open
prefer this.import instead of app.import#220brendenpalmer wants to merge 1 commit intoember-cli:masterfrom
this.import instead of app.import#220brendenpalmer wants to merge 1 commit intoember-cli:masterfrom
Conversation
rwjblue
requested changes
Jul 1, 2021
Member
rwjblue
left a comment
rwjblue
left a comment
There was a problem hiding this comment.
I think we probably need to try this.import and fallback to app.import.
I'm specifically worried about mega old ember-cli versions that don't have this.import, but folks are using the current major version of loader.js without issue.
brendenpalmer
force-pushed
the
bpalmer/use-find-host
branch
from
7e952b9 to
2bcb6c3
Compare
brendenpalmer
changed the title
this.import instead of app.importthis.import instead of app.import
|
This is biting me because I'm extracting an ember-engine from an app and currently have loader.js specified as an engine dependency... is "loader.js" considered a dependency of an engine? If not, why not? |
|
@rwjblue Any chance this could get merged? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
this allows using
loader.jsas a nested dependency;importinternally uses_findHostand callsimporton this: https://github.com/ember-cli/ember-cli/blob/master/lib/models/addon.js#L784